Fix use of length multiplier in several LibMesh methods#3773
Merged
pshriwise merged 1 commit intoopenmc-dev:developfrom Feb 5, 2026
Merged
Fix use of length multiplier in several LibMesh methods#3773pshriwise merged 1 commit intoopenmc-dev:developfrom
pshriwise merged 1 commit intoopenmc-dev:developfrom
Conversation
pshriwise
approved these changes
Feb 5, 2026
Contributor
pshriwise
left a comment
pshriwise
left a comment
There was a problem hiding this comment.
Thanks for catching these @paulromano! @nuclearkevin, look okay to you?
jon-proximafusion
pushed a commit
to shimwell/openmc
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#3694 changed how length scaling worked for
LibMesh, but it looks like it missed a few places that should have been scaled (sample_element()andlower_left_/upper_right_). This PR addresses those.Checklist
I have followed the style guidelines for Python source files (if applicable)